Преглед изворни кода

style: 流水线构建记录的result 字符串魔数抽取成静态变量

370774330@qq.com пре 5 година
родитељ
комит
cd70bb4e1d

+ 7 - 0
web/src/main/java/cn/seecoder/web/model/po/pipeline/PipelineRecordPO.java

@@ -18,6 +18,13 @@ import java.sql.Timestamp;
 @Builder
 public class PipelineRecordPO {
 
+    public final static String NO_RECORD = "无执行记录";
+
+    public final static String DEPLOYING = "部署中";
+
+    public final static String DEPLOY_SUCCESS = "部署成功";
+
+    public final static String DEPLOY_FAIL = "部署失败";
     /**
      * id
      */

+ 4 - 0
web/src/main/java/cn/seecoder/web/model/vo/pipeline/PipelineInfoVO.java

@@ -53,6 +53,10 @@ public class PipelineInfoVO {
             details = pipelineRecordPO.getDetails();
             recordId = pipelineRecordPO.getId();
             this.username = username;
+        } else {
+            result = PipelineRecordPO.NO_RECORD;
+            details = PipelineRecordPO.NO_RECORD;
+            this.username = "无";
         }
         name = pipelinePO.getName();
         id = pipelinePO.getId();

+ 4 - 4
web/src/main/java/cn/seecoder/web/service/impl/pipeline/DeploymentServiceImpl.java

@@ -98,7 +98,7 @@ public class DeploymentServiceImpl implements DeploymentService {
         ProjectPO projectPO = projectMapper.getProjectById(projectId);
         //历史记录
         PipelineRecordPO record = PipelineRecordPO.builder()
-                .result("部署中")
+                .result(PipelineRecordPO.DEPLOYING)
                 .pipelineId(pipelinePO.getId())
                 .userId(userId)
                 .details("")
@@ -128,15 +128,15 @@ public class DeploymentServiceImpl implements DeploymentService {
             pipeline = PipelineFactory.init(pipelinePO.getConfigJson(), projectPO.getUniqueK8sNamespace(), pipelinePO.getName());
             pipeline.addConfig("pipelineRecordId", record.getId().toString());
             pipeline.start();
-            record.setResult("部署成功");
+            record.setResult(PipelineRecordPO.DEPLOY_SUCCESS);
             record.setDetails(pipeline.getContext().getResult());
         } catch (PipelineException e) {
-            record.setResult("部署失败");
+            record.setResult(PipelineRecordPO.DEPLOY_FAIL);
             record.setDetails(pipeline.getContext().getResult());
             throw new ServiceException(HttpStatus.SC_INTERNAL_SERVER_ERROR,"应用部署失败",e);
         } catch (RuntimeException e){
             pipeline.getContext().appendErrorResult("运行时错误: ", e);
-            record.setResult("部署失败");
+            record.setResult(PipelineRecordPO.DEPLOY_FAIL);
             record.setDetails(pipeline.getContext().getResult());
             throw new ServiceException(HttpStatus.SC_INTERNAL_SERVER_ERROR,"应用部署失败",e);
         } finally {